chore(tech-debt): Remove built-in secret manager #592
Merged
+422
−5,307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
love to see it
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The built-in secret manager is an artifact of our deprecated cloud offering. It hasn't been supported for a while, and is unneeded tech debt. This PR completely removes the internal secret manager.
Tested the migration path and it works without errors when the Secrets table is empty. Surprisingly, it also seems to work when a secret is present (it just nukes the Secret table).
If you came to this PR because you've tried updating your Sourcebot deployment and are hitting issues with the DB migration, you will need to manually delete the Secret table in your DB. If you're using the internal DB then a clean wipe of your Sourcebot cache and restart should allow the migration to happen automatically. You'll need to switch to passing in secrets through environment variables (see docs for more details).